Thread (1 message) 1 message, 1 author, 2019-11-16
STALE2469d REVIEWED: 2 (0M)

2 review trailers.

[PATCH AUTOSEL 4.19 165/237] powerpc/powernv: hold device_hotplug_lock when calling device_online()

From: Sasha Levin <sashal@kernel.org>
Date: 2019-11-16 15:46:02
Also in: lkml, stable
Subsystem: linux for powerpc (32-bit and 64-bit), the rest · Maintainers: Madhavan Srinivasan, Linus Torvalds

From: David Hildenbrand <redacted>

[ Upstream commit cec1680591d6d5b10ecc10f370210089416e98af ]

device_online() should be called with device_hotplug_lock() held.

Link: http://lkml.kernel.org/r/20180925091457.28651-5-david@redhat.com
Signed-off-by: David Hildenbrand <redacted>
Reviewed-by: Pavel Tatashin <redacted>
Reviewed-by: Rashmica Gupta <redacted>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <redacted>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Rashmica Gupta <redacted>
Cc: Balbir Singh <bsingharora@gmail.com>
Cc: Michael Neuling <redacted>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Dan Williams <redacted>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Heiko Carstens <redacted>
Cc: John Allen <redacted>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Joonsoo Kim <redacted>
Cc: Juergen Gross <jgross@suse.com>
Cc: Kate Stewart <redacted>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Len Brown <lenb@kernel.org>
Cc: Martin Schwidefsky <redacted>
Cc: Mathieu Malaterre <redacted>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Nathan Fontenot <redacted>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: Philippe Ombredanne <redacted>
Cc: Rafael J. Wysocki <redacted>
Cc: "Rafael J. Wysocki" <redacted>
Cc: Stephen Hemminger <redacted>
Cc: Thomas Gleixner <redacted>
Cc: Vlastimil Babka <redacted>
Cc: YASUAKI ISHIMATSU <redacted>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/powerpc/platforms/powernv/memtrace.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/platforms/powernv/memtrace.c b/arch/powerpc/platforms/powernv/memtrace.c
index 232bf5987f91d..dd3cc4632b9ae 100644
--- a/arch/powerpc/platforms/powernv/memtrace.c
+++ b/arch/powerpc/platforms/powernv/memtrace.c
@@ -244,9 +244,11 @@ static int memtrace_online(void)
 		 * we need to online the memory ourselves.
 		 */
 		if (!memhp_auto_online) {
+			lock_device_hotplug();
 			walk_memory_range(PFN_DOWN(ent->start),
 					  PFN_UP(ent->start + ent->size - 1),
 					  NULL, online_mem_block);
+			unlock_device_hotplug();
 		}
 
 		/*
-- 
2.20.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help