Re: [PATCH V3 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm
From: Rob Herring <robh@kernel.org>
Date: 2019-11-14 21:12:41
Also in:
alsa-devel, linux-devicetree, lkml
On Mon, Nov 11, 2019 at 05:18:22PM +0800, Shengjiu Wang wrote:
Add compatible string "fsl,imx8qm-asrc" for imx8qm platform. There are two asrc modules in imx8qm, the clock mapping is different for each other, so add new property "fsl,asrc-clk-map" to distinguish them.
What's the clock mapping?
quoted hunk ↗ jump to hunk
Signed-off-by: Shengjiu Wang <redacted> --- changes in v2 -none changes in v3 -use only one compatible string "fsl,imx8qm-asrc", -add new property "fsl,asrc-clk-map". Documentation/devicetree/bindings/sound/fsl,asrc.txt | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt index 1d4d9f938689..02edab7cf3e0 100644 --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt@@ -8,7 +8,8 @@ three substreams within totally 10 channels. Required properties: - - compatible : Contains "fsl,imx35-asrc" or "fsl,imx53-asrc". + - compatible : Contains "fsl,imx35-asrc", "fsl,imx53-asrc", + "fsl,imx8qm-asrc". - reg : Offset and length of the register set for the device.@@ -35,6 +36,13 @@ Required properties: - fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends. + - fsl,asrc-clk-map : Defines clock map used in driver. which is required + by imx8qm/imx8qxp platform + <0> - select the map for asrc0 in imx8qm + <1> - select the map for asrc1 in imx8qm + <2> - select the map for asrc0 in imx8qxp + <3> - select the map for asrc1 in imx8qxp
Is this 4 modes of the h/w or just selecting 1 of 4 settings defined in the driver? How does one decide? This seems strange. imx8qxp should perhaps be a separate compatible. Then you only need 1 of 2 modes... Rob