Re: [PATCH V9] mm/debug: Add tests validating architecture page table helpers

On 11/12/2019 11:59 AM, Ingo Molnar wrote:

* Anshuman Khandual [off-list ref] wrote:

quoted

+config DEBUG_VM_PGTABLE
+	bool "Debug arch page table for semantics compliance"
+	depends on MMU
+	depends on DEBUG_VM
+	depends on ARCH_HAS_DEBUG_VM_PGTABLE
+	help
+	  This option provides a debug method which can be used to test
+	  architecture page table helper functions on various platforms in
+	  verifying if they comply with expected generic MM semantics. This
+	  will help architecture code in making sure that any changes or
+	  new additions of these helpers still conform to expected
+	  semantics of the generic MM.
+
+	  If unsure, say N.

Since CONFIG_DEBUG_VM is generally disabled in distro kernel packages, 
why not make this 'default y' to maximize testing coverage? The code size 
increase should be minimal, and DEBUG_VM increases size anyway.

Sure, will do.

Other than that this looks good to me:

  Reviewed-by: Ingo Molnar [off-list ref]

Thank you.

Thanks,

	Ingo