Re: [PATCH] powerpc/tools: Don't quote $objdump in scripts
From: Segher Boessenkool <hidden>
Date: 2019-10-24 18:55:25
From: Segher Boessenkool <hidden>
Date: 2019-10-24 18:55:25
On Thu, Oct 24, 2019 at 11:47:30AM +1100, Michael Ellerman wrote:
Some of our scripts are passed $objdump and then call it as "$objdump". This doesn't work if it contains spaces because we're using ccache, for example you get errors such as: ./arch/powerpc/tools/relocs_check.sh: line 48: ccache ppc64le-objdump: No such file or directory ./arch/powerpc/tools/unrel_branch_check.sh: line 26: ccache ppc64le-objdump: No such file or directory Fix it by not quoting the string when we expand it, allowing the shell to do the right thing for us.
This breaks things for people with spaces in their paths. Why doesn't your user use something like alias objdump="ccache ppc64le-objdump" , instead? Segher