Re: [PATCH 6/6] s390x: Mark archrandom.h functions __must_check
From: Harald Freudenberger <freude@linux.ibm.com>
Date: 2019-10-29 07:26:59
Also in:
linux-arch, linux-arm-kernel, linux-s390
On 28.10.19 22:05, Richard Henderson wrote:
quoted hunk ↗ jump to hunk
We cannot use the pointer output without validating the success of the random read. Signed-off-by: Richard Henderson <redacted> --- Cc: Heiko Carstens <redacted> Cc: Vasily Gorbik <gor@linux.ibm.com> Cc: Christian Borntraeger <redacted> --- arch/s390/include/asm/archrandom.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)diff --git a/arch/s390/include/asm/archrandom.h b/arch/s390/include/asm/archrandom.h index c67b82dfa558..f3f1ee0a8c38 100644 --- a/arch/s390/include/asm/archrandom.h +++ b/arch/s390/include/asm/archrandom.h@@ -33,17 +33,17 @@ static inline bool arch_has_random_seed(void) return false; } -static inline bool arch_get_random_long(unsigned long *v) +static inline bool __must_check arch_get_random_long(unsigned long *v) { return false; } -static inline bool arch_get_random_int(unsigned int *v) +static inline bool __must_check arch_get_random_int(unsigned int *v) { return false; } -static inline bool arch_get_random_seed_long(unsigned long *v) +static inline bool __must_check arch_get_random_seed_long(unsigned long *v) { if (static_branch_likely(&s390_arch_random_available)) { return s390_arch_random_generate((u8 *)v, sizeof(*v));@@ -51,7 +51,7 @@ static inline bool arch_get_random_seed_long(unsigned long *v) return false; } -static inline bool arch_get_random_seed_int(unsigned int *v) +static inline bool __must_check arch_get_random_seed_int(unsigned int *v) { if (static_branch_likely(&s390_arch_random_available)) { return s390_arch_random_generate((u8 *)v, sizeof(*v));
Fine with me, Thanks, reviewed, build and tested. You may add my reviewed-by: Harald Freudenberger [off-list ref] However, will this go into the kernel tree via crypto or s390 subsystem ?