Thread (54 messages) 54 messages, 8 authors, 2019-11-12

Re: [PATCH v2 01/29] powerpc: Rename "notes" PT_NOTE to "note"

From: Segher Boessenkool <hidden>
Date: 2019-10-30 01:02:20
Also in: linux-alpha, linux-arch, linux-arm-kernel, linux-s390, lkml

On Tue, Oct 29, 2019 at 02:15:39PM -0700, Kees Cook wrote:
On Tue, Oct 15, 2019 at 06:54:13PM +0200, Borislav Petkov wrote:
quoted
On Fri, Oct 11, 2019 at 11:25:52AM -0500, Segher Boessenkool wrote:
quoted
Names *matter*, internal names doubly so.  So why replace a good name with
a worse name?  Because it is slightly less work for you?
So if we agree on the name "notes" and we decide to rename the other
arches, this should all be done in a separate patchset anyway, and ontop
of this one. And I believe Kees wouldn't mind doing it ontop since he's
gotten his hands dirty already. :-P
I've added more rationale to patch #1 in the just-sent v3 of this
series. If I still can't convince you Segher, I'm happy to send "patch
30/29" to do a bulk rename to "notes". Let me know. :)
I am still not convinced the worse name is a better name, no :-)  But if
you don't want to do the work, and instead prefer the much smaller change,
that is of course a fine decision.  Thank you!

(I would be happy with such a 30/29 as well, of course.)


Segher
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help