Re: [PATCH v2 1/1] powerpc/pci: Fix pcibios_setup_device() ordering
From: Alexey Kardashevskiy <hidden>
Date: 2019-09-28 12:21:54
Also in:
linux-pci
From: Alexey Kardashevskiy <hidden>
Date: 2019-09-28 12:21:54
Also in:
linux-pci
On 28/09/2019 04:33, Shawn Anastasio wrote:
On 9/9/19 2:59 AM, Alexey Kardashevskiy wrote:quoted
On 06/09/2019 05:13, Shawn Anastasio wrote:quoted
Move PCI device setup from pcibios_add_device() and pcibios_fixup_bus() to pcibios_bus_add_device(). This ensures that platform-specific DMA and IOMMU setup occurs after the device has been registered in sysfs, which is a requirement for IOMMU group assignment to work This fixes IOMMU group assignment for hotplugged devices on pseries, where the existing behavior results in IOMMU assignment before registration.Although this is a correct approach which we should proceed with, this breaks adding of SRIOV VFs from pnv_tce_iommu_bus_notifier (and possibly the bare metal PCI hotplug), I am trying to fix that now...Were you able to make any progress? I can think of a couple of ways to fix SRIOV, but they're not particularly elegant and involve duplication.
A bigger change for ppc+pci is coming from Oliver (I guess with your patch as well) which will tackle this one too, soon. -- Alexey