Re: [PATCH 06/14] powerpc/eeh: Remove stale CAPI comment
From: Andrew Donnellan <hidden>
Date: 2019-09-03 14:13:31
On 3/9/19 8:15 pm, Oliver O'Halloran wrote:
Support for switching CAPI cards into and out of CAPI mode was removed a while ago. Drop the comment since it's no longer relevant. Cc: Andrew Donnellan <redacted> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Oliver looked... unimpressed with the hackiness of the design of our mode-switching as he yelled at me to come explain this comment. Acked-by: Andrew Donnellan <redacted>
quoted hunk ↗ jump to hunk
--- arch/powerpc/platforms/powernv/eeh-powernv.c | 7 ------- 1 file changed, 7 deletions(-)diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c b/arch/powerpc/platforms/powernv/eeh-powernv.c index e7b867912f24..94e26d56ecd2 100644 --- a/arch/powerpc/platforms/powernv/eeh-powernv.c +++ b/arch/powerpc/platforms/powernv/eeh-powernv.c@@ -1125,13 +1125,6 @@ static int pnv_eeh_reset(struct eeh_pe *pe, int option) return -EIO; } - /* - * If dealing with the root bus (or the bus underneath the - * root port), we reset the bus underneath the root port. - * - * The cxl driver depends on this behaviour for bi-modal card - * switching. - */ if (pci_is_root_bus(bus) || pci_is_root_bus(bus->parent)) return pnv_eeh_root_reset(hose, option);
-- Andrew Donnellan OzLabs, ADL Canberra ajd@linux.ibm.com IBM Australia Limited