On Tue, 2019-09-03 at 08:51 +0200, Christophe Leroy wrote:
<snip>

quoted

quoted

This piece of code looks pretty similar to the one before. Can we
refactor into a small helper ?

Not much point, it's removed in a subsequent patch.

But you tell me that you leave to people the opportunity to not
apply 
that subsequent patch, and that's the reason you didn't put that
patch 
before this one. In that case adding a helper is worth it.

Christophe

I factored it out anyway, since it made the code much nicer to read.

-- 
Alastair D'Silva
Open Source Developer
Linux Technology Centre, IBM Australia
mob: 0423 762 819