Re: linux-next: build warnings after merge of the kbuild tree
From: Masahiro Yamada <hidden>
Date: 2019-09-04 01:01:17
Also in:
linux-next, lkml
Hi Stephen, On Wed, Sep 4, 2019 at 9:13 AM Stephen Rothwell [off-list ref] wrote:
Hi all,
After merging the kbuild tree, today's linux-next build (powerpc
ppc64_defconfig) produced these warnings:
Presumably introduced by commit
1267f9d3047d ("kbuild: add $(BASH) to run scripts with bash-extension")
and presumably arch/powerpc/tools/unrel_branch_check.sh (which has no
#! line) is a bash script. Yeah, is uses '((' and '))'.Thanks for catching this. Could you fix it up as follows? I will squash it for tomorrow's linux-next.
--- a/arch/powerpc/Makefile.postlink
+++ b/arch/powerpc/Makefile.postlink@@ -18,7 +18,7 @@ quiet_cmd_relocs_check = CHKREL $@ ifdef CONFIG_PPC_BOOK3S_64 cmd_relocs_check = \ $(CONFIG_SHELL) $(srctree)/arch/powerpc/tools/relocs_check.sh
"$(OBJDUMP)" "$@" ; \
- $(CONFIG_SHELL)
$(srctree)/arch/powerpc/tools/unrel_branch_check.sh "$(OBJDUMP)" "$@"
+ $(BASH) $(srctree)/arch/powerpc/tools/unrel_branch_check.sh
"$(OBJDUMP)" "$@"
else
cmd_relocs_check = \
$(CONFIG_SHELL) $(srctree)/arch/powerpc/tools/relocs_check.sh
"$(OBJDUMP)" "$@"
-- Cheers, Stephen Rothwell
-- Best Regards Masahiro Yamada