Re: [PATCH v12 11/12] open: openat2(2) syscall
From: Randy Dunlap <rdunlap@infradead.org>
Date: 2019-09-04 21:00:30
Also in:
linux-alpha, linux-api, linux-arch, linux-arm-kernel, linux-fsdevel, linux-kselftest, linux-mips, linux-s390, linux-sh, lkml, sparclinux
Hi, just noisy nits here: On 9/4/19 1:19 PM, Aleksa Sarai wrote:
quoted hunk ↗ jump to hunk
diff --git a/include/uapi/linux/fcntl.h b/include/uapi/linux/fcntl.h index 1d338357df8a..479baf2da10e 100644 --- a/include/uapi/linux/fcntl.h +++ b/include/uapi/linux/fcntl.h@@ -93,5 +93,47 @@ #define AT_RECURSIVE 0x8000 /* Apply to the entire subtree */ +/**
/** means "the following is kernel-doc", but it's not, so please either make it kernel-doc format or just use /* to begin the comment.
+ * Arguments for how openat2(2) should open the target path. If @resolve is
+ * zero, then openat2(2) operates identically to openat(2).
+ *
+ * However, unlike openat(2), unknown bits in @flags result in -EINVAL rather
+ * than being silently ignored. In addition, @mode (or @upgrade_mask) must be
+ * zero unless one of {O_CREAT, O_TMPFILE, O_PATH} are set.
+ *
+ * @flags: O_* flags.
+ * @mode: O_CREAT/O_TMPFILE file mode.
+ * @upgrade_mask: UPGRADE_* flags (to restrict O_PATH re-opening).
+ * @resolve: RESOLVE_* flags.
+ */
+struct open_how {
+ __u32 flags;
+ union {
+ __u16 mode;
+ __u16 upgrade_mask;
+ };
+ __u16 resolve;
+};-- ~Randy