Re: [PATCH 1/3] scsi: cxlflash: Fix fallthrough warnings.
From: Uma Krishnan <hidden>
Date: 2019-08-29 21:37:31
<html><head></head><body dir="auto" style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="ApplePlainTextBody"><div class="ApplePlainTextBody">Below commit queued up for 5.4 includes these changes.<br><br>commit 657bd277c162580674ddb86a90c4aeb62639bff5<br>Author: Gustavo A. R. Silva <gustavo@embeddedor.com><br>Date: Sun Jul 28 19:21:19 2019 -0500<br><br>Thanks,<br>Uma Krishnan<br><br><blockquote type="cite">On Aug 29, 2019, at 7:32 AM, Michal Suchanek <msuchanek@suse.de> wrote:<br><br>Add fallthrough comments where missing.<br><br>Signed-off-by: Michal Suchanek <msuchanek@suse.de><br>---<br>drivers/scsi/cxlflash/main.c | 8 ++++++++<br>1 file changed, 8 insertions(+)<br><br>diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c<br>index b1f4724efde2..f402fa9a7bec 100644<br>--- a/drivers/scsi/cxlflash/main.c<br>+++ b/drivers/scsi/cxlflash/main.c<br>@@ -753,10 +753,13 @@ static void term_intr(struct cxlflash_cfg *cfg, enum undo_level level,<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>/* SISL_MSI_ASYNC_ERROR is setup only for the primary HWQ */<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>if (index == PRIMARY_HWQ)<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>cfg->ops->unmap_afu_irq(hwq->ctx_cookie, 3, hwq);<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>/* fall through */<br><span class="Apple-tab-span" style="white-space:pre"> </span>case UNMAP_TWO:<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>cfg->ops->unmap_afu_irq(hwq->ctx_cookie, 2, hwq);<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>/* fall through */<br><span class="Apple-tab-span" style="white-space:pre"> </span>case UNMAP_ONE:<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>cfg->ops->unmap_afu_irq(hwq->ctx_cookie, 1, hwq);<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>/* fall through */<br><span class="Apple-tab-span" style="white-space:pre"> </span>case FREE_IRQ:<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>cfg->ops->free_afu_irqs(hwq->ctx_cookie);<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>/* fall through */<br>@@ -973,14 +976,18 @@ static void cxlflash_remove(struct pci_dev *pdev)<br><span class="Apple-tab-span" style="white-space:pre"> </span>switch (cfg->init_state) {<br><span class="Apple-tab-span" style="white-space:pre"> </span>case INIT_STATE_CDEV:<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>cxlflash_release_chrdev(cfg);<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>/* fall through */<br><span class="Apple-tab-span" style="white-space:pre"> </span>case INIT_STATE_SCSI:<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>cxlflash_term_local_luns(cfg);<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>scsi_remove_host(cfg->host);<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>/* fall through */<br><span class="Apple-tab-span" style="white-space:pre"> </span>case INIT_STATE_AFU:<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>term_afu(cfg);<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>/* fall through */<br><span class="Apple-tab-span" style="white-space:pre"> </span>case INIT_STATE_PCI:<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>cfg->ops->destroy_afu(cfg->afu_cookie);<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>pci_disable_device(pdev);<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>/* fall through */<br><span class="Apple-tab-span" style="white-space:pre"> </span>case INIT_STATE_NONE:<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>free_mem(cfg);<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>scsi_host_put(cfg->host);<br>@@ -3017,6 +3024,7 @@ static ssize_t num_hwqs_store(struct device *dev,<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>wait_event(cfg->reset_waitq, cfg->state != STATE_RESET);<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>if (cfg->state == STATE_NORMAL)<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>goto retry;<br>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>/* fall through */<br><span class="Apple-tab-span" style="white-space:pre"> </span>default:<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>/* Ideally should not happen */<br><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>dev_err(dev, "%s: Device is not ready, state=%d\n",<br>-- <br>2.12.3<br><br></blockquote><br></div></body></html>