Re: [PATCH v5 1/2] powerpc/xmon: Allow listing and clearing breakpoints in read-only mode

From
Christopher M Riedl <hidden>
Date
2019-08-29 12:50:35
Reply to
Daniel Axtens, 2019-08-29
On August 29, 2019 at 1:40 AM Daniel Axtens [off-list ref] wrote:


Hi Chris,
quoted
Read-only mode should not prevent listing and clearing any active
breakpoints.
I tested this and it works for me:

Tested-by: Daniel Axtens <redacted>
quoted
+		if (xmon_is_ro || !scanhex(&a)) {
It took me a while to figure out what this line does: as I understand
it, the 'b' command can also be used to install a breakpoint (as well as
bi/bd). If we are in ro mode or if the input after 'b' doesn't scan as a
hex string, print the list of breakpoints instead. Anyway, I'm now
happy with it, so:
I can add a comment to that effect in the next version. That entire section
of code could probably be cleaned up a bit - but that's for another patch.
Thanks for testing!
Reviewed-by: Daniel Axtens <redacted>

Regards,
Daniel
quoted
 			/* print all breakpoints */
 			printf("   type            address\n");
 			if (dabr.enabled) {
-- 
2.23.0
Thread (7 messages) 7 messages, 2 authors, last reply 2019-08-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help