Re: [PATCH v5 05/12] powerpc/eeh: EEH for pSeries hot plug
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2019-08-21 03:30:10
Sam Bobroff [off-list ref] writes:
quoted hunk ↗ jump to hunk
diff --git a/arch/powerpc/kernel/of_platform.c b/arch/powerpc/kernel/of_platform.c index 427fc22f72b6..11c807468ab5 100644 --- a/arch/powerpc/kernel/of_platform.c +++ b/arch/powerpc/kernel/of_platform.c@@ -81,7 +81,8 @@ static int of_pci_phb_probe(struct platform_device *dev) pcibios_claim_one_bus(phb->bus); /* Finish EEH setup */ - eeh_add_device_tree_late(phb->bus); + if (!eeh_has_flag(EEH_FORCE_DISABLED)) + eeh_add_device_tree_late(phb->bus);
This breaks cell_defconfig which has CONFIG_EEH=n. That's because while eeh_add_device_tree_late() has an empty definition in that case, eeh_has_flag() and EEH_FORCE_DISABLED do not. Let me know how you want to fix it, if it's small just send me an incremental diff. cheers