Re: [PATCH v2 09/44] powerpc/64s/pseries: machine check convert to use common event code
From: Nicholas Piggin <npiggin@gmail.com>
Date: 2019-08-19 13:23:24
Michael Ellerman's on August 17, 2019 8:25 am:
kbuild test robot [off-list ref] writes:quoted
Hi Nicholas, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc3 next-20190807] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/powerpc-64s-exception-cleanup-and-macrofiy/20190802-222211 config: powerpc-defconfig (attached as .config) compiler: powerpc64-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=powerpc If you fix the issue, kindly add following tag Reported-by: kbuild test robot <redacted> All errors (new ones prefixed by >>): arch/powerpc/platforms/pseries/ras.c: In function 'mce_handle_error':quoted
quoted
arch/powerpc/platforms/pseries/ras.c:563:28: error: this statement may fall through [-Werror=implicit-fallthrough=]mce_err.u.ue_error_type = MCE_UE_ERROR_IFETCH; ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ arch/powerpc/platforms/pseries/ras.c:564:3: note: here case MC_ERROR_UE_PAGE_TABLE_WALK_IFETCH: ^~~~ arch/powerpc/platforms/pseries/ras.c:565:28: error: this statement may fall through [-Werror=implicit-fallthrough=] mce_err.u.ue_error_type = MCE_UE_ERROR_PAGE_TABLE_WALK_IFETCH; ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/platforms/pseries/ras.c:566:3: note: here case MC_ERROR_UE_LOAD_STORE: ^~~~ arch/powerpc/platforms/pseries/ras.c:567:28: error: this statement may fall through [-Werror=implicit-fallthrough=] mce_err.u.ue_error_type = MCE_UE_ERROR_LOAD_STORE; ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/platforms/pseries/ras.c:568:3: note: here case MC_ERROR_UE_PAGE_TABLE_WALK_LOAD_STORE: ^~~~ arch/powerpc/platforms/pseries/ras.c:569:28: error: this statement may fall through [-Werror=implicit-fallthrough=] mce_err.u.ue_error_type = MCE_UE_ERROR_PAGE_TABLE_WALK_LOAD_STORE; ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/platforms/pseries/ras.c:570:3: note: here case MC_ERROR_UE_INDETERMINATE: ^~~~ cc1: all warnings being treated as errorsI think you meant to break in all these cases?
Yes I did. I might have had a couple of other minor fixes in the series and have since retested guest mce injection so I'd perhaps better resend the series. Thanks, Nick