Re: [PATCH v4 7/9] powerpc/eeh: Add bdfn field to eeh_dev

On Thu, Aug 8, 2019 at 5:05 PM Jordan Niethe [off-list ref] wrote:

On Wed, 2019-08-07 at 13:44 +1000, Sam Bobroff wrote:

quoted

From: Oliver O'Halloran <oohall@gmail.com>

Preparation for removing pci_dn from the powernv EEH code. The only
thing we really use pci_dn for is to get the bdfn of the device for
config space accesses, so adding that information to eeh_dev reduces
the need to carry around the pci_dn.

Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
[SB: Re-wrapped commit message, fixed whitespace damage.]
Signed-off-by: Sam Bobroff <redacted>
---
 arch/powerpc/include/asm/eeh.h     | 2 ++
 arch/powerpc/include/asm/ppc-pci.h | 2 ++
 arch/powerpc/kernel/eeh_dev.c      | 2 ++
 3 files changed, 6 insertions(+)

diff --git a/arch/powerpc/include/asm/eeh.h

b/arch/powerpc/include/asm/eeh.h
index 7f9404a0c3bb..bbe0798f6624 100644

--- a/arch/powerpc/include/asm/eeh.h
+++ b/arch/powerpc/include/asm/eeh.h

@@ -121,6 +121,8 @@ static inline bool eeh_pe_passed(struct eeh_pe

*pe)
 struct eeh_dev {
      int mode;                       /* EEH mode                     */
      int class_code;                 /* Class code of the device
*/
+     int bdfn;                       /* bdfn of device (for cfg ops) */
+     struct pci_controller *controller;

The other members of the structure get a comment, maybe it would be
more consistant if this one did too?

At some point we need to go through all the EEH documentation /
comments and get rid of everything that is not useful or just straight
up wrong. The comments here are in-offensive, but they mostly just
repeat the information in the variable name so it's hard to see the
value.