Thread (2 messages) 2 messages, 2 authors, 2019-08-02

Re: [PATCH v2] crypto: nx: nx-842-powernv: Add of_node_put() before return

flat view

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2019-08-02 04:55:38
Also in: linux-crypto

On Wed, Jul 24, 2019 at 01:24:33PM +0530, Nishka Dasgupta wrote:
Each iteration of for_each_compatible_node puts the previous node, but
in the case of a return from the middle of the loop, there is no put,
thus causing a memory leak. Add an of_node_put before the return.
Issue found with Coccinelle.

Acked-by: Stewart Smith <redacted>
Signed-off-by: Nishka Dasgupta <redacted>

---
Changes in v2:
- Fixed commit message to match the loop in question.

 drivers/crypto/nx/nx-842-powernv.c | 1 +
 1 file changed, 1 insertion(+)
Patch applied.  Thanks.
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help