Re: [PATCH v3 2/4] powerpc: expose secure variables to userspace via sysfs

On Mon, Aug 26, 2019 at 11:46:11AM -0400, Nayna wrote:

On 08/26/2019 10:56 AM, Greg Kroah-Hartman wrote:

quoted

On Mon, Aug 26, 2019 at 09:23:36AM -0400, Nayna Jain wrote:

quoted

+static struct kobj_attribute size_attr = __ATTR_RO(size);

Wait, why not just normal ATTR_RO()?

Oh!! Sorry. I am not seeing this macro in sysfs.h. am I missing something ?

Ugh, no, you are right, I thought it was there as the BIN_ATTR_RO() one
was there :)

quoted

quoted

+static struct bin_attribute data_attr = __BIN_ATTR_RO(data, VARIABLE_MAX_SIZE);

And BIN_ATTR_RO() here?

This would have worked. I think I just thought to use the same way as
__ATTR_RO().

Yes, that's fine to use, sorry for the noise.

greg k-h