Thread (7 messages) flat view 7 messages, 2 authors, 2019-08-22

Re: [PATCH 1/5] powerpc/ptdump: fix addresses display on PPC32

From: Christophe Leroy <hidden>
Date: 2019-08-14 12:51:32
Also in: lkml

Michael,

Le 14/08/2019 à 14:36, Christophe Leroy a écrit :
Commit 453d87f6a8ae ("powerpc/mm: Warn if W+X pages found on boot")
wrongly changed KERN_VIRT_START from 0 to PAGE_OFFSET, leading to a
shift in the displayed addresses.

Lets revert that change to resync walk_pagetables()'s addr val and
pgd_t pointer for PPC32.

Fixes: 453d87f6a8ae ("powerpc/mm: Warn if W+X pages found on boot")
Either this patch or patch 2 of the series has to go into fixes.

If you prefer next patch for fixes, then this one can be squashed into 
patch 3 which drops the PPC32 hacked definition of KERN_VIRT_START

Christophe
quoted hunk ↗ jump to hunk
Cc: stable@vger.kernel.org
Signed-off-by: Christophe Leroy <redacted>
---
  arch/powerpc/mm/ptdump/ptdump.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/mm/ptdump/ptdump.c b/arch/powerpc/mm/ptdump/ptdump.c
index 6a88a9f585d4..3ad64fc11419 100644
--- a/arch/powerpc/mm/ptdump/ptdump.c
+++ b/arch/powerpc/mm/ptdump/ptdump.c
@@ -27,7 +27,7 @@
  #include "ptdump.h"
  
  #ifdef CONFIG_PPC32
-#define KERN_VIRT_START	PAGE_OFFSET
+#define KERN_VIRT_START	0
  #endif
  
  /*
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help