Re: [PATCHv6 1/2] PCI: layerscape: Add the bar_fixed_64bit property in EP driver.
From: Lorenzo Pieralisi <hidden>
Date: 2019-08-14 09:30:01
Also in:
linux-arm-kernel, linux-pci, lkml
I asked you to remove the period at the end of the patch $SUBJECT and you did not, either you do not read what I write or explain me what's going on. On Wed, Aug 14, 2019 at 10:03:29AM +0800, Xiaowei Bao wrote:
The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 is 32bit, BAR2 and BAR4 is 64bit, this is determined by hardware, so set the bar_fixed_64bit with 0x14. Signed-off-by: Xiaowei Bao <redacted>
Kishon ACK'ed this patch and you have not carried his tag. I will make these changes but that's the last time I do that for you. Lorenzo
quoted hunk ↗ jump to hunk
--- v2: - Replace value 0x14 with a macro. v3: - No change. v4: - send the patch again with '--to'. v5: - fix the commit message. v6: - remove the [EXT] tag of the $SUBJECT in email. drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c index be61d96..ca9aa45 100644 --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c@@ -44,6 +44,7 @@ static const struct pci_epc_features ls_pcie_epc_features = { .linkup_notifier = false, .msi_capable = true, .msix_capable = false, + .bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4), }; static const struct pci_epc_features*-- 2.9.5