RE: [EXT] Re: [PATCHv4 1/2] PCI: layerscape: Add the bar_fixed_64bit property in EP driver.

-----Original Message-----
From: Kishon Vijay Abraham I <redacted>
Sent: 2019年8月13日 12:36
To: Xiaowei Bao <redacted>; lorenzo.pieralisi@arm.com;
bhelgaas@google.com; M.h. Lian [off-list ref]; Mingkai Hu
[off-list ref]; Roy Zang [off-list ref];
l.stach@pengutronix.de; tpiepho@impinj.com; Leonard Crestez
[off-list ref]; andrew.smirnov@gmail.com;
yue.wang@amlogic.com; hayashi.kunihiko@socionext.com;
dwmw@amazon.co.uk; jonnyc@amazon.com; linux-pci@vger.kernel.org;
linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org;
linux-arm-kernel@lists.infradead.org
Subject: [EXT] Re: [PATCHv4 1/2] PCI: layerscape: Add the bar_fixed_64bit
property in EP driver.

Caution: EXT Email

On 13/08/19 8:23 AM, Xiaowei Bao wrote:

quoted

The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 is
32bit, BAR3 and BAR4 is 64bit, this is determined by hardware,

Do you mean BAR2 instead of BAR3 here?

Yes.

Thanks
Kishon

quoted

so set the bar_fixed_64bit with 0x14.

Signed-off-by: Xiaowei Bao <redacted>
---
v2:
 - Replace value 0x14 with a macro.
v3:
 - No change.
v4:
 - send the patch again with '--to'.

 drivers/pci/controller/dwc/pci-layerscape-ep.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c

b/drivers/pci/controller/dwc/pci-layerscape-ep.c
index be61d96..227c33b 100644

--- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
+++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c

@@ -44,6 +44,7 @@ static int ls_pcie_establish_link(struct dw_pcie *pci)
      .linkup_notifier = false,
      .msi_capable = true,
      .msix_capable = false,
+     .bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4),
 };

 static const struct pci_epc_features*