Thread (27 messages) 27 messages, 6 authors, 2019-08-10

Re: [PATCH] powerpc: fix inline asm constraints for dcbz

flat view

From: Nathan Chancellor <hidden>
Date: 2019-08-09 20:36:55
Also in: lkml

On Fri, Aug 09, 2019 at 11:21:05AM -0700, Nick Desaulniers wrote:
The input parameter is modified, so it should be an output parameter
with "=" to make it so that a copy of the input is not made by Clang.

Link: https://bugs.llvm.org/show_bug.cgi?id=42762
Link: https://gcc.gnu.org/onlinedocs/gcc/Modifiers.html#Modifiers
Link: https://github.com/ClangBuiltLinux/linux/issues/593
Link: https://godbolt.org/z/QwhZXi
Link: https://lore.kernel.org/lkml/20190721075846.GA97701@archlinux-threadripper/ (local)
Fixes: 6c5875843b87 ("powerpc: slightly improve cache helpers")
Debugged-by: Nathan Chancellor [off-list ref]
Reported-by: Nathan Chancellor <redacted>
Reported-by: kbuild test robot <redacted>
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Suggested-by: Nathan Chancellor <redacted>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
I applied this patch as well as a revert of the original patch and both
clang and GCC appear to generate the same code; I think a straight
revert would be better.

Crude testing script and the generated files attached.

Cheers,
Nathan

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help