Re: [PATCH 1/4] fs: always build llseek.
From: Eric W. Biederman <hidden>
Date: 2019-08-28 18:13:31
Also in:
linux-fsdevel, lkml
Michal Suchanek [off-list ref] writes:
64bit !COMPAT does not build because the llseek syscall is in the tables.
Do I read this right you have a 128 bit offset to llseek on ppc64? Looking at the signature it does not appear to make sense to build this function on any 64bit platform. Perhaps the proper fix to to take llseek out of your syscall tables? Eric
quoted hunk
Signed-off-by: Michal Suchanek <redacted> --- fs/read_write.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/fs/read_write.c b/fs/read_write.c index 5bbf587f5bc1..9db56931eb26 100644 --- a/fs/read_write.c +++ b/fs/read_write.c@@ -331,7 +331,6 @@ COMPAT_SYSCALL_DEFINE3(lseek, unsigned int, fd, compat_off_t, offset, unsigned i } #endif -#if !defined(CONFIG_64BIT) || defined(CONFIG_COMPAT) SYSCALL_DEFINE5(llseek, unsigned int, fd, unsigned long, offset_high, unsigned long, offset_low, loff_t __user *, result, unsigned int, whence)@@ -360,7 +359,6 @@ SYSCALL_DEFINE5(llseek, unsigned int, fd, unsigned long, offset_high, fdput_pos(f); return retval; } -#endif int rw_verify_area(int read_write, struct file *file, const loff_t *ppos, size_t count) {