Re: [PATCH v3 5/7] kexec_elf: remove elf_addr_to_cpu macro
flat view
From: Sven Schnelle <hidden>
Date: 2019-07-15 07:26:32
Also in:
kexec
Hi Michael, On Thu, Jul 11, 2019 at 09:08:51PM +1000, Michael Ellerman wrote:
Sven Schnelle [off-list ref] writes:quoted
On Wed, Jul 10, 2019 at 05:09:29PM +0200, Christophe Leroy wrote:quoted
Le 10/07/2019 à 16:29, Sven Schnelle a écrit :quoted
It had only one definition, so just use the function directly.It had only one definition because it was for ppc64 only. But as far as I understand (at least from the name of the new file), you want it to be generic, don't you ? Therefore I get on 32 bits it would be elf32_to_cpu().That brings up the question whether we need those endianess conversions. I would assume that the ELF file has always the same endianess as the running kernel. So i think we could just drop them. What do you think?We should be able to kexec from big to little endian or vice versa, so they are necessary.
I'll update the patch to check for a needed 32/64 bit conversion during runtime, so we can also kexec from 32 to 64 bit kernels and vice versa. Don't know whether that's possible on powerpc, but at least on parisc it is. Regards Sven