Thread (3 messages) 3 messages, 2 authors, 2019-07-09

Re: powerpc/83xx: fix use-after-free on mpc831x_usb_cfg()

flat view

From: <hidden>
Date: 2019-07-09 02:23:57

quoted
The np variable is still being used after the of_node_put() call,
quoted
which may result in use-after-free.
quoted
We fix this issue by calling of_node_put() after the last usage.

I imagine that this commit description can be improved a bit more
(by mentioning the influence of “immr_node”?).
How do you think about to omit the word “We” here?

quoted
This patatch also do some cleanup.

Should the renaming of a jump label be contributed in a separate update
step of a small patch series besides a wording without a typo?
Thank you for your comments.
We will improve the commit description and send v2 as soon as possible.

--
Regards,
Wen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help