Thread (7 messages) 7 messages, 4 authors, 2019-07-04

Re: [PATCH v2] powerpc/pseries: Fix maximum memory value

From: Aravinda Prasad <hidden>
Date: 2019-07-01 04:05:15


On Friday 28 June 2019 10:57 PM, Nathan Lynch wrote:
Aravinda Prasad [off-list ref] writes:
quoted
Calculating the maximum memory based on the number of lmbs
and lmb size does not account for the RMA region. Hence
use memory_hotplug_max(), which already accounts for the
RMA region, to fetch the maximum memory value. Thanks to
Nathan Lynch for suggesting the memory_hotplug_max()
function.
Well, I hope I haven't led you astray... will it give you the desired
result on a kernel configured without memory hotplug support, booted in
an LPAR with some huge pages configured?
Yes. I have tested the patch both with CONFIG_MEMORY_HOTPLUG set and not
set. It is working as expected.

Regards,
Aravinda
If so, then
Acked-by: Nathan Lynch <redacted>

It would likely help with review and future maintenance if the semantics
and intended use of the MaxMem field are made a little more
explicit. For example, is it supposed to include persistent memory?
Perhaps a follow-up patch could address this. Or maybe I'm overthinking
it.
-- 
Regards,
Aravinda
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help