Re: [PATCH v2 0/5] mm: Enable CONFIG_NODES_SPAN_OTHER_NODES by default for NUMA
From: Hoan Tran OS <hoan@os.amperecomputing.com>
Date: 2019-07-30 17:32:59
Also in:
linux-arm-kernel, linux-mm, linux-s390, lkml, sparclinux
Hi, On 7/30/19 1:14 AM, Michal Hocko wrote:
[Sorry for a late reply] On Mon 15-07-19 17:55:07, Hoan Tran OS wrote:quoted
Hi, On 7/12/19 10:00 PM, Michal Hocko wrote:[...]quoted
quoted
Hmm, I thought this was selectable. But I am obviously wrong here. Looking more closely, it seems that this is indeed only about __early_pfn_to_nid and as such not something that should add a config symbol. This should have been called out in the changelog though.Yes, do you have any other comments about my patch?Not really. Just make sure to explicitly state that CONFIG_NODES_SPAN_OTHER_NODES is only about __early_pfn_to_nid and that doesn't really deserve it's own config and can be pulled under NUMA.
Yes, I will add this info into the patch description.
quoted
quoted
Also while at it, does HAVE_MEMBLOCK_NODE_MAP fall into a similar bucket? Do we have any NUMA architecture that doesn't enable it?As I checked with arch Kconfig files, there are 2 architectures, riscv and microblaze, do not support NUMA but enable this config. And 1 architecture, alpha, supports NUMA but does not enable this config.Care to have a look and clean this up please?
Sure, I'll take a look. Thanks Hoan