Thread (8 messages) 8 messages, 5 authors, 2019-08-02

Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through

flat view

From: Stephen Rothwell <hidden>
Date: 2019-07-30 04:45:30
Also in: lkml

Hi all,

On Tue, 30 Jul 2019 14:37:04 +1000 Stephen Rothwell [off-list ref] wrote:
Mark switch cases where we are expecting to fall through.

This patch fixes the following warning (Building: powerpc):

drivers/macintosh/smu.c: In function 'smu_queue_i2c':
drivers/macintosh/smu.c:854:21: warning: this statement may fall through [-Wimplicit-fallthrough=]
   cmd->info.devaddr &= 0xfe;
   ~~~~~~~~~~~~~~~~~~^~~~~~~
drivers/macintosh/smu.c:855:2: note: here
  case SMU_I2C_TRANSFER_STDSUB:
  ^~~~

Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Gustavo A. R. Silva <redacted>
Cc: Kees Cook <redacted>
Signed-off-by: Stephen Rothwell <redacted>
Fixes: 0365ba7fb1fa ("[PATCH] ppc64: SMU driver update & i2c support")

Sorry, forgot :-)
-- 
Cheers,
Stephen Rothwell

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help