Re: [PATCH v3] tpm: tpm_ibm_vtpm: Fix unallocated banks

From
Michal Suchánek <hidden>
Date
2019-07-16 17:52:42
Also in
linux-integrity, lkml
Reply to
Jarkko Sakkinen, 2019-07-11
On Fri, 12 Jul 2019 00:13:57 +0300
Jarkko Sakkinen [off-list ref] wrote:
On Thu, Jul 11, 2019 at 11:28:24PM +0300, Jarkko Sakkinen wrote:
quoted
On Thu, Jul 11, 2019 at 12:13:35PM -0400, Nayna Jain wrote:  
quoted
The nr_allocated_banks and allocated banks are initialized as part of
tpm_chip_register. Currently, this is done as part of auto startup
function. However, some drivers, like the ibm vtpm driver, do not run
auto startup during initialization. This results in uninitialized memory
issue and causes a kernel panic during boot.

This patch moves the pcr allocation outside the auto startup function
into tpm_chip_register. This ensures that allocated banks are initialized
in any case.

Fixes: 879b589210a9 ("tpm: retrieve digest size of unknown algorithms with
PCR read")
Reported-by: Michal Suchanek <redacted>
Signed-off-by: Nayna Jain <nayna@linux.ibm.com>
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
Tested-by: Sachin Sant <redacted>
Tested-by: Michal Suchánek <redacted>  
Reviewed-by: Jarkko Sakkinen <redacted>  
Thanks a lot! It is applied now.
Fixes the issue for me.

Thanks

Michal
Thread (4 messages) 4 messages, 3 authors, last reply 2019-07-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help