Re: [PATCH] powerpc/hw_breakpoint: move instruction stepping out of hw_breakpoint_handler()
From: Ravi Bangoria <hidden>
Date: 2019-07-08 03:41:06
Also in:
lkml
On 7/6/19 1:56 PM, Christophe Leroy wrote:
Le 03/07/2019 à 08:20, Ravi Bangoria a écrit :quoted
On 6/28/19 9:25 PM, Christophe Leroy wrote:quoted
On 8xx, breakpoints stop after executing the instruction, so stepping/emulation is not needed. Move it into a sub-function and remove the #ifdefs. Signed-off-by: Christophe Leroy <redacted> ---Reviewed-by: Ravi Bangoria <redacted> Just one neat below...Thanks for the review.quoted
[...]quoted
-#ifndef CONFIG_PPC_8xx - /* Do not emulate user-space instructions, instead single-step them */ - if (user_mode(regs)) { - current->thread.last_hit_ubp = bp; - regs->msr |= MSR_SE; + if (!IS_ENABLED(CONFIG_PPC_8xx) && !stepping_handler(regs, bp, info->address))May be split this line. It's 86 chars long and checkpatch.pl is warning about this:Didn't you use arch/powerpc/tools/checkpatch.sh ? powerpc accepts 90 chars per line.
Hmm.. wasn't aware of it. Thanks!