Thread (68 messages) 68 messages, 7 authors, 2019-07-19

Re: [PATCH v3 10/11] mm/memory_hotplug: Make unregister_memory_block_under_nodes() never fail

From: Oscar Salvador <osalvador@suse.de>
Date: 2019-07-01 09:36:51
Also in: linux-arm-kernel, linux-mm, linux-s390, linux-sh, lkml

On Mon, Jul 01, 2019 at 10:51:44AM +0200, Michal Hocko wrote:
Yeah, we do not allow to offline multi zone (node) ranges so the current
code seems to be over engineered.

Anyway, I am wondering why do we have to strictly check for already
removed nodes links. Is the sysfs code going to complain we we try to
remove again?
No, sysfs will silently "fail" if the symlink has already been removed.
At least that is what I saw last time I played with it.

I guess the question is what if sysfs handling changes in the future
and starts dropping warnings when trying to remove a symlink is not there.
Maybe that is unlikely to happen?

-- 
Oscar Salvador
SUSE L3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help