Re: [PATCH v9 10/10] selftests: add openat2(2) selftests
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2019-07-08 01:15:57
Also in:
linux-alpha, linux-api, linux-arch, linux-arm-kernel, linux-fsdevel, linux-kselftest, linux-mips, linux-s390, linux-sh, lkml, sparclinux
Hi Aleksa, A few minor comments below. Aleksa Sarai [off-list ref] writes:
quoted hunk ↗ jump to hunk
diff --git a/tools/testing/selftests/openat2/Makefile b/tools/testing/selftests/openat2/Makefile new file mode 100644 index 000000000000..8235a49928f6 --- /dev/null +++ b/tools/testing/selftests/openat2/Makefile@@ -0,0 +1,12 @@ +# SPDX-License-Identifier: GPL-2.0 + +CFLAGS += -Wall -O2 -g +TEST_GEN_PROGS := linkmode_test resolve_test rename_attack_test + +include ../lib.mk + +$(OUTPUT)/linkmode_test: linkmode_test.c helpers.o +$(OUTPUT)/rename_attack_test: rename_attack_test.c helpers.o +$(OUTPUT)/resolve_test: resolve_test.c helpers.o
You don't need to tell make that foo depends on foo.c. Also if you make the dependency be on helpers.c then you won't get an intermediate helpers.o, and then you don't need to clean it. So the above three lines could just be: $(TEST_GEN_PROGS): helpers.c
+EXTRA_CLEAN = helpers.o $(wildcard /tmp/ksft-openat2-*)
If you follow my advice above you don't need helpers.o in there. Deleting things from /tmp is also a bit fishy on shared machines, ie. it will error if those files happen to be owned by another user. cheers