Thread (2 messages) 2 messages, 2 authors, 2019-06-30

Re: [PATCH] powerpc/pseries: avoid blocking in irq when queuing hotplug events

From: Michael Ellerman <hidden>
Date: 2019-06-30 08:41:09

On Tue, 2019-05-28 at 23:28:01 UTC, Nathan Lynch wrote:
A couple of bugs in queue_hotplug_event():

1. Unchecked kmalloc result which could lead to an oops.
2. Use of GFP_KERNEL allocations in interrupt context (this code's
   only caller is ras_hotplug_interrupt()).

Use kmemdup to avoid open-coding the allocation+copy and check for
failure; use GFP_ATOMIC for both allocations.

Ultimately it probably would be better to avoid or reduce allocations
in this path if possible.

Signed-off-by: Nathan Lynch <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/348ea30f51fc63ce3c7fd7dba6043e8e3ee0ef34

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help