Re: [PATCH] i2c: remove casting dma_alloc

Jochen Friedrich · 2019-06-29T13:41:02+0200

Hi Wolfram, yes, I'm still here. However, I don't have the hardware anymore to test the patch. Thanks, Jochen Am 29.06.2019 13:34 schrieb Wolfram Sang <wsa@the-dreams.de>: On Sun, Jun 23, 2019 at 11:13:53PM +0200, Vasyl Gomonovych wrote: > From: Vasyl <gomonovych@gmail.com> > > Generated by: alloc_cast.cocci > > Signed-off-by: Vasyl <gomonovych@gmail.com> Your other patches in git history have your full name. Why not this one? @Jochen: are you still there, your ack would be very welcome. > --- > drivers/i2c/busses/i2c-cpm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c > index 187900594e3d..1213e1932ccb 100644 > --- a/drivers/i2c/busses/i2c-cpm.c > +++ b/drivers/i2c/busses/i2c-cpm.c > @@ -531,7 +531,9 @@ static int cpm_i2c_setup(struct cpm_i2c *cpm) > } > out_be32(&rbdf[i].cbd_bufaddr, ((cpm->rxdma[i] + 1) & ~1)); > > - cpm->txbuf[i] = (unsigned char *)dma_alloc_coherent(&cpm->ofdev->dev, CPM_MAX_READ + 1, &cpm->txdma[i], GFP_KERNEL); > + cpm->txbuf[i] = dma_alloc_coherent(&cpm->ofdev->dev, > + CPM_MAX_READ + 1, > + &cpm->txdma[i], GFP_KERNEL); > if...

From: Jochen Friedrich <jochen@scram.de>
Date: 2019-06-30 04:30:13
Also in: linux-i2c

<div dir='auto'>Hi Wolfram,<div dir="auto"><br></div><div dir="auto">yes, I'm still here. However, I don't have the hardware anymore to test the patch.</div><div dir="auto"><br></div><div dir="auto">Thanks, Jochen&nbsp;</div></div><div class="gmail_extra"><br><div class="gmail_quote">Am 29.06.2019 13:34 schrieb Wolfram Sang &lt;wsa@the-dreams.de&gt;:<br type="attribution" /><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">On Sun, Jun 23, 2019 at 11:13:53PM +0200, Vasyl Gomonovych wrote:&#13;<br>
&gt; From: Vasyl &lt;gomonovych@gmail.com&gt;&#13;<br>
&gt; &#13;<br>
&gt; Generated by:&nbsp; alloc_cast.cocci&#13;<br>
&gt; &#13;<br>
&gt; Signed-off-by: Vasyl &lt;gomonovych@gmail.com&gt;&#13;<br>
&#13;<br>
Your other patches in git history have your full name. Why not this one?&#13;<br>
&#13;<br>
@Jochen: are you still there, your ack would be very welcome.&#13;<br>
&#13;<br>
&gt; ---&#13;<br>
&gt;&nbsp; drivers/i2c/busses/i2c-cpm.c | 4 +++-&#13;<br>
&gt;&nbsp; 1 file changed, 3 insertions(+), 1 deletion(-)&#13;<br>
&gt; &#13;<br>
&gt; diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c&#13;<br>
&gt; index 187900594e3d..1213e1932ccb 100644&#13;<br>
&gt; --- a/drivers/i2c/busses/i2c-cpm.c&#13;<br>
&gt; +++ b/drivers/i2c/busses/i2c-cpm.c&#13;<br>
&gt; @@ -531,7 +531,9 @@ static int cpm_i2c_setup(struct cpm_i2c *cpm)&#13;<br>
&gt;&nbsp; &#9;&#9;}&#13;<br>
&gt;&nbsp; &#9;&#9;out_be32(&amp;rbdf[i].cbd_bufaddr, ((cpm-&gt;rxdma[i] + 1) &amp; ~1));&#13;<br>
&gt;&nbsp; &#13;<br>
&gt; -&#9;&#9;cpm-&gt;txbuf[i] = (unsigned char *)dma_alloc_coherent(&amp;cpm-&gt;ofdev-&gt;dev, CPM_MAX_READ + 1, &amp;cpm-&gt;txdma[i], GFP_KERNEL);&#13;<br>
&gt; +&#9;&#9;cpm-&gt;txbuf[i] = dma_alloc_coherent(&amp;cpm-&gt;ofdev-&gt;dev,&#13;<br>
&gt; +&#9;&#9;&#9;&#9;&#9;&#9;&nbsp;&nbsp; CPM_MAX_READ + 1,&#13;<br>
&gt; +&#9;&#9;&#9;&#9;&#9;&#9;&nbsp;&nbsp; &amp;cpm-&gt;txdma[i], GFP_KERNEL);&#13;<br>
&gt;&nbsp; &#9;&#9;if (!cpm-&gt;txbuf[i]) {&#13;<br>
&gt;&nbsp; &#9;&#9;&#9;ret = -ENOMEM;&#13;<br>
&gt;&nbsp; &#9;&#9;&#9;goto out_muram;&#13;<br>
&gt; -- &#13;<br>
&gt; 2.17.1&#13;<br>
&gt; &#13;<br>
</p>
</blockquote></div><br></div>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help