Re: [PATCH 03/16] mm: lift the x86_32 PAE version of gup_get_pte to common code
flat view
From: Jason Gunthorpe <jgg@ziepe.ca>
Date: 2019-06-21 13:45:35
Also in:
linux-mips, linux-mm, linux-sh, lkml, sparclinux
On Tue, Jun 11, 2019 at 04:40:49PM +0200, Christoph Hellwig wrote:
The split low/high access is the only non-READ_ONCE version of gup_get_pte that did show up in the various arch implemenations. Lift it to common code and drop the ifdef based arch override. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/x86/Kconfig | 1 + arch/x86/include/asm/pgtable-3level.h | 47 ------------------------ arch/x86/kvm/mmu.c | 2 +- mm/Kconfig | 3 ++ mm/gup.c | 51 ++++++++++++++++++++++++--- 5 files changed, 52 insertions(+), 52 deletions(-)
Yep, the sh and mips conversions look right too. Reviewed-by: Jason Gunthorpe <redacted>
quoted hunk ↗ jump to hunk
diff --git a/mm/Kconfig b/mm/Kconfig index f0c76ba47695..fe51f104a9e0 100644 --- a/mm/Kconfig +++ b/mm/Kconfig@@ -762,6 +762,9 @@ config GUP_BENCHMARK See tools/testing/selftests/vm/gup_benchmark.c +config GUP_GET_PTE_LOW_HIGH + bool +
The config name seems a bit out of place though, should it be prefixed with GENERIC_ or ARCH_? Jason