Thread (1 message) 1 message, 1 author, 2019-06-11

Re: [BISECTED REGRESSION] b43legacy broken on G4 PowerBook

From: Andreas Schwab <hidden>
Date: 2019-06-11 17:48:16
Also in: linux-wireless, lkml

On Jun 10 2019, Larry Finger [off-list ref] wrote:
I do not understand why the if statement returns true as neither of the
values is zero.
That's because the format string does not make any sense.  You are
printing garbage.
quoted hunk
diff --git a/kernel/dma/mapping.c b/kernel/dma/mapping.c
index f7afdad..ba2489d 100644
--- a/kernel/dma/mapping.c
+++ b/kernel/dma/mapping.c
@@ -317,9 +317,12 @@ int dma_supported(struct device *dev, u64 mask)

 int dma_set_mask(struct device *dev, u64 mask)
 {
+       pr_info("mask 0x%llx, dma_mask 0x%llx, dma_supported 0x%llx\n",
mask, dev->dma_mask,
+               dma_supported(dev, mask));
None of the format directives match the type of the arguments.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help