Thread (3 messages) flat view 3 messages, 3 authors, 2019-05-20

Re: [PATCH v2] ocxl: Fix potential memory leak on context creation

From: Andrew Donnellan <hidden>
Date: 2019-05-20 07:20:05

Acked-by: Andrew Donnellan <redacted>

On 20/5/19 5:16 pm, Frederic Barrat wrote:
quoted hunk ↗ jump to hunk
If we couldn't fully init a context, we were leaking memory.

Fixes: b9721d275cc2 ("ocxl: Allow external drivers to use OpenCAPI contexts")
Signed-off-by: Frederic Barrat <redacted>
---

Changelog:
v2: reset context pointer in case of allocation failure (Andrew)

  drivers/misc/ocxl/context.c | 2 ++
  1 file changed, 2 insertions(+)
diff --git a/drivers/misc/ocxl/context.c b/drivers/misc/ocxl/context.c
index bab9c9364184..24e4fb010275 100644
--- a/drivers/misc/ocxl/context.c
+++ b/drivers/misc/ocxl/context.c
@@ -22,6 +22,8 @@ int ocxl_context_alloc(struct ocxl_context **context, struct ocxl_afu *afu,
  			afu->pasid_base + afu->pasid_max, GFP_KERNEL);
  	if (pasid < 0) {
  		mutex_unlock(&afu->contexts_lock);
+		kfree(*context);
+		*context = NULL;
  		return pasid;
  	}
  	afu->pasid_count++;
-- 
Andrew Donnellan              OzLabs, ADL Canberra
ajd@linux.ibm.com             IBM Australia Limited
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help