Thread (24 messages) flat view 24 messages, 4 authors, 2019-05-09

Re: [PATCH v2 09/16] powernv/fadump: process architected register state data provided by firmware

From: Hari Bathini <hbathini@linux.ibm.com>
Date: 2019-05-09 04:44:17

On 07/05/19 9:30 PM, Segher Boessenkool wrote:
On Tue, May 07, 2019 at 07:43:56PM +0530, Mahesh J Salgaonkar wrote:
quoted
Can we use SPRN_* #defines which are already present in asm/reg.h instead of
hard coding numbers for switch cases ? You may want to add new #defines
for NIP, MSR and CCR.
But none of those three are SPRs.  Please don't pollute that namespace.
Put such defines into some fadump header, instead?
Sure, Segher.
I will stick with adding the defines in fadump header for the missing regs..
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help