Re: [PATCH v1 4/8] soc/fsl/qbman: Use index when accessing device tree properties
flat view
From: Joakim Tjernlund <hidden>
Date: 2019-05-13 16:40:43
Also in:
linux-arm-kernel, lkml
On Mon, 2019-05-13 at 16:09 +0000, Roy Pledge wrote:
The index value should be passed to the of_parse_phandle() function to ensure the correct property is read.
Is this a bug fix? Maybe for stable too? Jocke
quoted hunk ↗ jump to hunk
Signed-off-by: Roy Pledge <redacted> --- drivers/soc/fsl/qbman/dpaa_sys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/soc/fsl/qbman/dpaa_sys.c b/drivers/soc/fsl/qbman/dpaa_sys.c index 3e0a7f3..0b901a8 100644 --- a/drivers/soc/fsl/qbman/dpaa_sys.c +++ b/drivers/soc/fsl/qbman/dpaa_sys.c@@ -49,7 +49,7 @@ int qbman_init_private_mem(struct device *dev, int idx, dma_addr_t *addr, idx, ret); return -ENODEV; } - mem_node = of_parse_phandle(dev->of_node, "memory-region", 0); + mem_node = of_parse_phandle(dev->of_node, "memory-region", idx); if (mem_node) { ret = of_property_read_u64(mem_node, "size", &size64); if (ret) { --2.7.4