Re: [PATCH] vsprintf: Do not break early boot with probing addresses

On Fri, May 10, 2019 at 12:24:01PM -0400, Steven Rostedt wrote:

On Fri, 10 May 2019 10:42:13 +0200
Petr Mladek [off-list ref] wrote:

quoted

 static const char *check_pointer_msg(const void *ptr)
 {
-	char byte;
-
 	if (!ptr)
 		return "(null)";
 
-	if (probe_kernel_address(ptr, byte))
+	if ((unsigned long)ptr < PAGE_SIZE || IS_ERR_VALUE(ptr))
 		return "(efault)";
 

	< PAGE_SIZE ?

do you mean: < TASK_SIZE ?

Original code used PAGE_SIZE. If it needs to be changed, that it might be a
separate explanation / patch.

-- 
With Best Regards,
Andy Shevchenko