Re: [PATCH V1] ASoC: fsl_esai: replace fall-through with break
From: Gustavo A. R. Silva <hidden>
Date: 2019-04-08 16:19:51
Also in:
alsa-devel
On 4/8/19 4:28 AM, S.j. Wang wrote:
case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of each other, so replace fall-through with break.
If this is correct, then you should use the following "Fixes" tag instead,
which is the one that introduced the bug:
Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver")
Fixes: 16bbeb2b43c3 ("ASoC: fsl_esai: Mark expected switch fall-through")^^^^ because this didn't change any functionality.
quoted hunk ↗ jump to hunk
Signed-off-by: Shengjiu Wang <redacted> --- sound/soc/fsl/fsl_esai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index c7410bbfd2af..bad0dfed6b68 100644 --- a/sound/soc/fsl/fsl_esai.c +++ b/sound/soc/fsl/fsl_esai.c@@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id, break; case ESAI_HCKT_EXTAL: ecr |= ESAI_ECR_ETI;
Also, you should use a simple assignment operator "=" instead of "|=" in both cases.
- /* fall through */ + break; case ESAI_HCKR_EXTAL: ecr |= esai_priv->synchronous ? ESAI_ECR_ETI : ESAI_ECR_ERI; break;
Thanks -- Gustavo