Re: [PATCH RFC 3/5] powerpc/speculation: Add support for 'cpu_spec_mitigations=' cmdline options

From
Timothy Pearson <tpearson@raptorengineering.com>
Date
2019-04-04 20:09:52
Also in
linux-arch, linux-arm-kernel, linux-s390, lkml
Reply to
Jiri Kosina, 2019-04-04
Will be joining in ~ 5 mins.  Getting Chromium set up here.

----- Original Message -----
From: "Jiri Kosina" <jikos@kernel.org>
To: "Josh Poimboeuf" <redacted>
Cc: "Peter Zijlstra" <peterz@infradead.org>, "Heiko Carstens" <redacted>, "Paul Mackerras"
[off-list ref], "H . Peter Anvin" [off-list ref], "Ingo Molnar" [off-list ref], "Andrea Arcangeli"
[off-list ref], linux-s390@vger.kernel.org, x86@kernel.org, "Will Deacon" [off-list ref], "Linus
Torvalds" [off-list ref], "Catalin Marinas" [off-list ref], "Waiman Long"
[off-list ref], linux-arch@vger.kernel.org, "Jon Masters" [off-list ref], "Borislav Petkov" [off-list ref],
"Andy Lutomirski" [off-list ref], "Thomas Gleixner" [off-list ref], linux-arm-kernel@lists.infradead.org,
"Greg Kroah-Hartman" [off-list ref], linux-kernel@vger.kernel.org, "Tyler Hicks" [off-list ref],
"Martin Schwidefsky" [off-list ref], linuxppc-dev@lists.ozlabs.org
Sent: Thursday, April 4, 2019 2:49:05 PM
Subject: Re: [PATCH RFC 3/5] powerpc/speculation: Add support for 'cpu_spec_mitigations=' cmdline options
On Thu, 4 Apr 2019, Josh Poimboeuf wrote:
quoted
Configure powerpc CPU runtime speculation bug mitigations in accordance
with the 'cpu_spec_mitigations=' cmdline options.  This affects
Meltdown, Spectre v1, Spectre v2, and Speculative Store Bypass.
[ ... snip ... ]
quoted
-	if (!no_nospec)
+	if (!no_nospec && cpu_spec_mitigations != CPU_SPEC_MITIGATIONS_OFF)
'!no_nospec' is something that I am sure will come back to hunt me in my
bad dreams.

But that's been there already, and fixing it is out of scope of this
patch. Other than that, as discussed previously -- I really like this new
global option. Feel free to add

Reviewed-by: Jiri Kosina <redacted>

for the whole set.

Thanks,

--
Jiri Kosina
SUSE Labs
Thread (33 messages) 33 messages, 10 authors, last reply 2019-04-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help