RE: [alsa-devel] [PATCH] ASoC: cs42xx8: Remove S32_LE in format list

It would be a mistake to remove S32_LE from the format list.

If you removed that, then we wouldn't be able to do 32 bit native playback
- it would force users to go through an ALSA plugin.

If you look at the cs42448 data sheet for example, the I2S and TDM bus
uses a 32 bit word size. For that reason, native S32_LE format is handled by
the codec. While the codec only uses the 24 MSBs, the I2S bus is 32 bit.

This case is covered by S24_LE I think.  The S32_LE means the data is 32bit and slot width
Is 32bit, this is not in data sheet.

Best regards
Wang shengjiu

Matt

On 1/3/19 3:50 pm, Nicolin Chen wrote:

quoted

Hi Shengjiu,

On Thu, Feb 28, 2019 at 05:56:31AM +0000, S.j. Wang wrote:

quoted

cs42xx8 is a 24-bit A/D and 24-bit D/A device, so the S32_LE should
not be in the supported format list.

Signed-off-by: Shengjiu Wang <redacted>
---
  sound/soc/codecs/cs42xx8.c | 3 +--

This is for cs42xx8 codec driver, but its maintainers aren't seemly in
To/Cc list. Please run ./scripts/get_maintainer.pl for it and resend.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org

https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fma
i

quoted

lman.alsa-project.org%2Fmailman%2Flistinfo%2Falsa-

devel&data=02%7C

quoted

01%7Cshengjiu.wang%40nxp.com%7Ce5686d72bd7843c5962508d69e0370a4
%7C686e

quoted

a1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C636870134975623123&
sdata=Rr

quoted

YwfC4Y3xssED%2FzRum%2FXABGJTHvRrYwnRNgUL7u2lU%3D&reserved
=0