Re: [PATCH -next] ocxl: remove set but not used variables 'tid' and 'lpid'
From: Mukesh Ojha <hidden>
Date: 2019-03-29 21:29:52
Also in:
lkml
On 3/29/2019 9:14 PM, Yue Haibing wrote:
From: YueHaibing <redacted> Fixes gcc '-Wunused-but-set-variable' warning: drivers/misc/ocxl/link.c: In function 'xsl_fault_handler': drivers/misc/ocxl/link.c:187:17: warning: variable 'tid' set but not used [-Wunused-but-set-variable] drivers/misc/ocxl/link.c:187:6: warning: variable 'lpid' set but not used [-Wunused-but-set-variable] They are never used and can be removed. Signed-off-by: YueHaibing <redacted>
Reviewed-by: Mukesh Ojha <redacted> Cheers, -Mukesh
quoted hunk ↗ jump to hunk
--- drivers/misc/ocxl/link.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/drivers/misc/ocxl/link.c b/drivers/misc/ocxl/link.c index d50b861..3be07e9 100644 --- a/drivers/misc/ocxl/link.c +++ b/drivers/misc/ocxl/link.c@@ -184,7 +184,7 @@ static irqreturn_t xsl_fault_handler(int irq, void *data) u64 dsisr, dar, pe_handle; struct pe_data *pe_data; struct ocxl_process_element *pe; - int lpid, pid, tid; + int pid; bool schedule = false; read_irq(spa, &dsisr, &dar, &pe_handle);@@ -192,9 +192,7 @@ static irqreturn_t xsl_fault_handler(int irq, void *data) WARN_ON(pe_handle > SPA_PE_MASK); pe = spa->spa_mem + pe_handle; - lpid = be32_to_cpu(pe->lpid); pid = be32_to_cpu(pe->pid); - tid = be32_to_cpu(pe->tid); /* We could be reading all null values here if the PE is being * removed while an interrupt kicks in. It's not supposed to * happen if the driver notified the AFU to terminate the