[PATCH v2 01/45] drivers: tty: serial: 8250_bcm2835aux: use devm_platform_ioremap_resource()
From: "Enrico Weigelt, metux IT consult" <info@metux.net>
Date: 2019-03-14 22:35:06
Also in:
linux-arm-msm, linux-serial, lkml
Subsystem:
8250/16?50 (and clone uarts) serial driver, the rest, tty layer and serial drivers · Maintainers:
Greg Kroah-Hartman, Linus Torvalds, Jiri Slaby
For the common platform_get_resource()+devm_platform_ioremap() combination, there is a helper, so use it and make the code a bit more compact. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> --- drivers/tty/serial/8250/8250_bcm2835aux.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_bcm2835aux.c b/drivers/tty/serial/8250/8250_bcm2835aux.c
index bd53661..0738d14 100644
--- a/drivers/tty/serial/8250/8250_bcm2835aux.c
+++ b/drivers/tty/serial/8250/8250_bcm2835aux.c@@ -25,7 +25,6 @@ struct bcm2835aux_data { static int bcm2835aux_serial_probe(struct platform_device *pdev) { struct bcm2835aux_data *data; - struct resource *res; int ret; /* allocate the custom structure */
@@ -63,15 +62,12 @@ static int bcm2835aux_serial_probe(struct platform_device *pdev) data->uart.port.irq = ret; /* map the main registers */ - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(&pdev->dev, "memory resource not found"); - return -EINVAL; - } - data->uart.port.membase = devm_ioremap_resource(&pdev->dev, res); + data->uart.port.membase = devm_platform_ioremap_resource(pdev, 0); ret = PTR_ERR_OR_ZERO(data->uart.port.membase); - if (ret) + if (ret) { + dev_err(&pdev->dev, "could not map memory resource"); return ret; + } /* Check for a fixed line number */ ret = of_alias_get_id(pdev->dev.of_node, "serial");
--
1.9.1