Thread (2 messages) flat view 2 messages, 2 authors, 2019-02-22

Re: [PATCH] KVM: PPC: Book3S HV: Fix build failure without IOMMU support

From: Paul Mackerras <hidden>
Date: 2019-02-22 09:53:30

On Thu, Feb 21, 2019 at 02:28:48PM +1100, Jordan Niethe wrote:
Currently trying to build without IOMMU support will fail:

  (.text+0x1380): undefined reference to `kvmppc_h_get_tce'
  (.text+0x1384): undefined reference to `kvmppc_rm_h_put_tce'
  (.text+0x149c): undefined reference to `kvmppc_rm_h_stuff_tce'
  (.text+0x14a0): undefined reference to `kvmppc_rm_h_put_tce_indirect'

This happens because turning off IOMMU support will prevent
book3s_64_vio_hv.c from being built because it is only built when
SPAPR_TCE_IOMMU is set, which depends on IOMMU support.

Fix it using ifdefs for the undefined references.

Fixes: 76d837a4c0f9 ("KVM: PPC: Book3S PR: Don't include SPAPR TCE code on non-pseries platforms")
Signed-off-by: Jordan Niethe <redacted>
Thanks, applied to my kvm-ppc-next tree.

Paul.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help