RE: [PATCH][next] soc: fsl: dpio: fix memory leak of a struct qbman on error exit path
From: Leo Li <hidden>
Date: 2019-02-19 20:57:42
Also in:
kernel-janitors, linux-arm-kernel, lkml
-----Original Message----- From: Colin King <redacted> Sent: Tuesday, February 19, 2019 8:05 AM To: Roy Pledge <redacted>; Leo Li <redacted>; linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org Subject: [PATCH][next] soc: fsl: dpio: fix memory leak of a struct qbman on error exit path From: Colin Ian King <redacted> Currently the error check for a null reg leaks a struct qbman that was allocated earlier. Fix this by kfree'ing p on the error exit path. Signed-off-by: Colin Ian King <redacted>
Applied for next. Thanks.
quoted hunk ↗ jump to hunk
--- drivers/soc/fsl/dpio/qbman-portal.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/soc/fsl/dpio/qbman-portal.cb/drivers/soc/fsl/dpio/qbman-portal.c index 0bddb85c0ae5..5a73397ae79e 100644--- a/drivers/soc/fsl/dpio/qbman-portal.c +++ b/drivers/soc/fsl/dpio/qbman-portal.c@@ -180,6 +180,7 @@ struct qbman_swp *qbman_swp_init(const structqbman_swp_desc *d) reg = qbman_read_register(p, QBMAN_CINH_SWP_CFG); if (!reg) { pr_err("qbman: the portal is not enabled!\n"); + kfree(p); return NULL; } -- 2.20.1