On Fri, 2019-02-15 at 16:55 +0900, Masahiro Yamada wrote:

+CC: Ley Foon Tan [off-list ref]
+CC: nios2-dev@lists.rocketboards.org


On Thu, Feb 14, 2019 at 2:40 AM Christoph Hellwig [off-list ref] wrote:

quoted

diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig
index 715e6c09b4a5..3b50689007f5 100644
--- a/arch/nios2/Kconfig
+++ b/arch/nios2/Kconfig

@@ -20,6 +20,7 @@ config NIOS2

        select OF_EARLY_FLATTREE
        select SOC_BUS
        select SPARSE_IRQ
+       select TRACE_IRQFLAGS_SUPPORT

This is a behavior change of nios2.

TRACE_IRQFLAGS_SUPPORT was previously 'n',
and this commit is changing it to 'y'.




Strangely, nios2 defines TRACE_IRQFLAGS_SUPPORT twice
with different default values.

In Kconfig, the first one becomes effective.

In this case, 'def_bool n' in arch/nios2/Kconfig is used.
'def_bool y' in arch/nios2/Kconfig.debug is dead code.


I think this select should be dropped
to keep the current behavior,
but I hope the NIOS2 maintainer will give us
some comments just in case.

Yes, please drop this patch to keep original behavior.
Thanks.

Regards
Ley Foon

quoted

        select USB_ARCH_HAS_HCD if USB_SUPPORT
        select CPU_NO_EFFICIENT_FFS
        select ARCH_DISCARD_MEMBLOCK

@@ -39,9 +40,6 @@ config NO_IOPORT_MAP

 config FPU
        def_bool n

-config TRACE_IRQFLAGS_SUPPORT
-       def_bool n
-
 menu "Kernel features"

 source "kernel/Kconfig.hz"

diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug
index f1da8a7b17ff..a8bc06e96ef5 100644
--- a/arch/nios2/Kconfig.debug
+++ b/arch/nios2/Kconfig.debug

@@ -1,8 +1,5 @@

 # SPDX-License-Identifier: GPL-2.0

-config TRACE_IRQFLAGS_SUPPORT
-       def_bool y
-
 config EARLY_PRINTK
        bool "Activate early kernel debugging"
        default y

--
Best Regards
Masahiro Yamada

________________________________

Confidentiality Notice.
This message may contain information that is confidential or
otherwise protected from disclosure. If you are not the intended
recipient, you are hereby notified that any use, disclosure,
dissemination, distribution, or copying of this message, or any
attachments, is strictly prohibited. If you have received this
message in error, please advise the sender by reply e-mail, and
delete the message and any attachments. Thank you.