Thread (5 messages) 5 messages, 3 authors, 2019-02-05

Re: [RFC PATCH] powerpc: fix get_arch_dma_ops() for NTB devices

flat view

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2019-01-30 13:00:25

Alexander Fomichev [off-list ref] writes:
get_dma_ops() falls into arch-dependant get_arch_dma_ops(), which
historically returns NULL on PowerPC. Therefore dma_set_mask() fails.
This affects Switchtec (and probably other) NTB devices, that they fail
to initialize.
What's an NTB device?

drivers/ntb I assume?

So it's a PCI device of some sort, but presumably the device you're
calling dma_set_mask() on is an NTB device not a PCI device?

But then it works if you tell it to use the PCI DMA ops?

At the very least the code should be checking for the NTB bus type and
only returning the PCI ops in that specific case, not for all devices.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help