Re: [PATCH v3 1/2] selftests/powerpc: Add MSR bits

Hi Breno,

Le 07/01/2019 à 13:44, Breno Leitao a écrit :

hi Christophe,

On 1/3/19 3:19 PM, LEROY Christophe wrote:

quoted

Breno Leitao [off-list ref] a écrit :

quoted

This patch simply adds definitions for the MSR bits and some macros to
test for MSR TM bits.

This was copied from arch/powerpc/include/asm/reg.h generic MSR part.

Can't we find a way to avoid duplicating such defines ?

I think there are three possible ways, but none of them respect the premises
we are used too. These are the possible ways I can think of:

1) Including arch/powerpc/include/asm as part of the selftest compilation
process.
    Problem: This might break the selftest independence of the kbuild system.

2) Generate a temporary header file inside selftests/include which contains
these macros at compilation time.
    Problem: The problem as above.

3) Define MSR fields at userspace headers (/usr/include).
    Problem: I am not sure userspace should have MSR bits information.

Do you suggest me to investigate any other way?

Looking it other .h in selftests, it looks like they are limited to the only strictly necessary values.

Are all the values you have listed used ? If not, could you only include in the file the necessary ones ?

Christophe